Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified so that connection timeout and read timeout can be set when … #1053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modified so that connection timeout and read timeout can be set when … #1053

wants to merge 1 commit into from

Conversation

stager0909
Copy link

…calling oauth2.googleapis.com in ServiceAccountCredentials.refreshAccessToken()

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@stager0909-ray
Modified so that connection timeout and read timeout can be set when …
8d513d6 
…calling oauth2.googleapis.com in ServiceAccountCredentials.refreshAccessToken()
@stager0909 stager0909 requested a review from a team as a code owner October 13, 2022 07:39
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 13, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@google-cla
Copy link

google-cla bot commented Oct 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 13, 2022
@stager0909 stager0909 mentioned this pull request Oct 13, 2022
Open
@TimurSadykov
Copy link
Member

@stager0909 Hi, Thanks for your contribution. Do you have an issue opened for this? If not please open one and provide a description of the problem you are trying to solve.

@stager0909
Copy link
Author

@TimurSadykov Hi
My merge request is related to the issue below.
The default value of connectionTimeout and readTimeout of google credential is 20 seconds, but I hope that it can be changed by injecting this.

#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stager0909 @TimurSadykov @stager0909-ray